Skip to content

Add an instruction to link the plan/session in the PR - #85235

Merged
akhera99 merged 1 commit into
dotnet:mainfrom
akhera99:update_instruction_for_plan_approval
Sep 10, 2026
Merged

Add an instruction to link the plan/session in the PR#85235
akhera99 merged 1 commit into
dotnet:mainfrom
akhera99:update_instruction_for_plan_approval

Conversation

@akhera99

@akhera99 akhera99 commented Sep 9, 2026

Copy link
Copy Markdown
Member
Microsoft Reviewers: Open in CodeFlow

Copilot AI lite review requested due to automatic review settings September 9, 2026 23:28
@akhera99
akhera99 requested a review from a team as a code owner September 9, 2026 23:28
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
2 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Two moderate documentation issues and one nit remain unresolved.

Review tier: Lite
Findings: None

What changed in this PR

This documentation-only PR adds guidance for linking the plan and Copilot session when pausing work for approval.

Changes:

  • Documents incomplete PR status and remaining work.
  • Adds plan/session-linking guidance.
File Summary Findings
.github/​copilot-instructions.md Adds plan-approval handoff instructions. Moderate (1 vote): define usable links and a fallback. Moderate (1 vote): make updates append-only. Nit (1 vote): document the convention in .github/memory/CONVENTIONS.md.
Suppressed comments (3)

.github/copilot-instructions.md:126

  • Could this define what counts as a usable session link and provide a fallback when the Copilot surface does not expose a stable, shareable URL? As written, this is mandatory, but an agent may only have a local session/plan.md and no URL it can put in GitHub; allowing the plan and approval request to be included inline when no shareable link exists avoids inaccessible or unverifiable links.
If a pull request already exists when work pauses for plan approval, update its description or add a comment that clearly states the implementation is **not complete**, summarizes what remains, and links to the Copilot session containing the plan and approval request so the user can provide further instructions.

.github/copilot-instructions.md:126

  • This introduces a new repo-wide workflow pattern, but the existing documentation rule at lines 94-99 requires repo-wide patterns to be recorded in .github/memory/CONVENTIONS.md. Please add the session/PR-linking convention there as well, or explicitly document why this canonical instruction is intentionally the sole source, so agents that load the memory conventions do not miss it.
If a pull request already exists when work pauses for plan approval, update its description or add a comment that clearly states the implementation is **not complete**, summarizes what remains, and links to the Copilot session containing the plan and approval request so the user can provide further instructions.

.github/copilot-instructions.md:126

  • Could this be made explicitly append-only? “Update its description” is ambiguous and could lead an agent to replace the author’s existing summary, acceptance criteria, or reviewer context while adding the handoff note. Please require appending without deleting existing content (or prefer a new comment) so the pause/approval handoff remains auditable.
If a pull request already exists when work pauses for plan approval, update its description or add a comment that clearly states the implementation is **not complete**, summarizes what remains, and links to the Copilot session containing the plan and approval request so the user can provide further instructions.

@akhera99
akhera99 merged commit b6bbb3d into dotnet:main Sep 10, 2026
5 of 7 checks passed
@dotnet-policy-service dotnet-policy-service Bot added this to the Next milestone Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants