Add an instruction to link the plan/session in the PR - #85235
Merged
akhera99 merged 1 commit intoSep 10, 2026
Conversation
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Two moderate documentation issues and one nit remain unresolved.
Review tier: Lite
Findings: None
What changed in this PR
This documentation-only PR adds guidance for linking the plan and Copilot session when pausing work for approval.
Changes:
- Documents incomplete PR status and remaining work.
- Adds plan/session-linking guidance.
| File | Summary | Findings |
|---|---|---|
.github/copilot-instructions.md |
Adds plan-approval handoff instructions. | Moderate (1 vote): define usable links and a fallback. Moderate (1 vote): make updates append-only. Nit (1 vote): document the convention in .github/memory/CONVENTIONS.md. |
Suppressed comments (3)
.github/copilot-instructions.md:126
- Could this define what counts as a usable session link and provide a fallback when the Copilot surface does not expose a stable, shareable URL? As written, this is mandatory, but an agent may only have a local session/
plan.mdand no URL it can put in GitHub; allowing the plan and approval request to be included inline when no shareable link exists avoids inaccessible or unverifiable links.
If a pull request already exists when work pauses for plan approval, update its description or add a comment that clearly states the implementation is **not complete**, summarizes what remains, and links to the Copilot session containing the plan and approval request so the user can provide further instructions.
.github/copilot-instructions.md:126
- This introduces a new repo-wide workflow pattern, but the existing documentation rule at lines 94-99 requires repo-wide patterns to be recorded in
.github/memory/CONVENTIONS.md. Please add the session/PR-linking convention there as well, or explicitly document why this canonical instruction is intentionally the sole source, so agents that load the memory conventions do not miss it.
If a pull request already exists when work pauses for plan approval, update its description or add a comment that clearly states the implementation is **not complete**, summarizes what remains, and links to the Copilot session containing the plan and approval request so the user can provide further instructions.
.github/copilot-instructions.md:126
- Could this be made explicitly append-only? “Update its description” is ambiguous and could lead an agent to replace the author’s existing summary, acceptance criteria, or reviewer context while adding the handoff note. Please require appending without deleting existing content (or prefer a new comment) so the pause/approval handoff remains auditable.
If a pull request already exists when work pauses for plan approval, update its description or add a comment that clearly states the implementation is **not complete**, summarizes what remains, and links to the Copilot session containing the plan and approval request so the user can provide further instructions.
333fred
approved these changes
Sep 10, 2026
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow